Skip to content

docs: fix ci for webpack.js.org #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

chenxsan
Copy link
Contributor

@chenxsan chenxsan commented Oct 18, 2020

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ x] metadata update

Motivation / Use-Case

The link https://webpack.js.org/configuration/#options:~:text=ignoreWarnings was added in #129, I think the author used it as a workaround because the URL should be used here is currently blocked by this pull request webpack/webpack.js.org#4076.

Now options:~:text=ignoreWarnings was recognized as ID (which I believe is a bug as :~:text=ignoreWarnings is a text fragment, but I'm not sure if it'll be a bug in hyperlink or somewhere else) and webpack.js.org doesn't have it in the page which caused the failure of CI.

This pull request removes the paragraph temporarily to fix CI for webpack.js.org. We can add it back later when webpack/webpack.js.org#4076 get merged.

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          212       212           
  Branches        56        56           
=========================================
  Hits           212       212           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f38cd1...adb5c18. Read the comment docs.

@alexander-akait
Copy link
Member

We should fix it in future

@alexander-akait alexander-akait merged commit ae3a7b1 into webpack-contrib:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants